Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept $schema entity in the FileSpec schema #2549

Merged
merged 3 commits into from
May 21, 2024
Merged

Accept $schema entity in the FileSpec schema #2549

merged 3 commits into from
May 21, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented May 11, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Fix #2495

@yahavi yahavi added the improvement Automatically generated release notes label May 11, 2024
@yahavi yahavi requested review from eyalbe4 and sverdlov93 May 11, 2024 15:24
@yahavi yahavi self-assigned this May 11, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label May 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 11, 2024
@yahavi yahavi linked an issue May 11, 2024 that may be closed by this pull request
Property $schema is not allowed #2495
Closed
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label May 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 12, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label May 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 12, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label May 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 21, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label May 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 21, 2024
@yahavi yahavi merged commit d394f04 into jfrog:dev May 21, 2024
62 of 63 checks passed
@yahavi yahavi deleted the schema-schema branch May 21, 2024 12:17
@BrewTestBot BrewTestBot mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@sverdlov93 sverdlov93 Awaiting requested review from sverdlov93

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Property $schema is not allowed
2 participants
@yahavi @sverdlov93