Add external dependencies rewrite parameters for helm remote repos

jfrog · Nov 3, 2022 · a8d9ece · a8d9ece
1 parent adc3175
commit a8d9ece
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/artifactory/services/remoterepository.go b/artifactory/services/remoterepository.go
@@ -367,7 +367,9 @@ func NewGradleRemoteRepositoryParams() GradleRemoteRepositoryParams {
 
 type HelmRemoteRepositoryParams struct {
 	RemoteRepositoryBaseParams
-	ChartsBaseUrl string `json:"chartsBaseUrl,omitempty"`
+	ChartsBaseUrl                string   `json:"chartsBaseUrl,omitempty"`
+	ExternalDependenciesEnabled  bool     `json:"externalDependenciesEnabled,omitempty"`
+	ExternalDependenciesPatterns []string `json:"externalDependenciesPatterns,omitempty"`
 }
 
 func NewHelmRemoteRepositoryParams() HelmRemoteRepositoryParams {

diff --git a/tests/artifactoryremoterepository_test.go b/tests/artifactoryremoterepository_test.go
@@ -531,6 +531,8 @@ func remoteHelmTest(t *testing.T) {
 	hrp.Url = "https://storage.googleapis.com/kubernetes-charts"
 	setRemoteRepositoryBaseParams(&hrp.RemoteRepositoryBaseParams, false)
 	hrp.ChartsBaseUrl = "charts"
+	hrp.ExternalDependenciesEnabled = true
+	hrp.ExternalDependenciesPatterns = []string{"https://github.com/**"}
 
 	err := testsCreateRemoteRepositoryService.Helm(hrp)
 	if !assert.NoError(t, err, "Failed to create "+repoKey) {
@@ -543,6 +545,8 @@ func remoteHelmTest(t *testing.T) {
 
 	setRemoteRepositoryBaseParams(&hrp.RemoteRepositoryBaseParams, true)
 	hrp.ChartsBaseUrl = ""
+	hrp.ExternalDependenciesEnabled = false
+	hrp.ExternalDependenciesPatterns = []string{}
 
 	err = testsUpdateRemoteRepositoryService.Helm(hrp)
 	assert.NoError(t, err, "Failed to update "+repoKey)