Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Entitlement Service #749

Merged
merged 6 commits into from
May 22, 2023
Merged

New Entitlement Service #749

merged 6 commits into from
May 22, 2023

Conversation

talarian1
Copy link
Contributor

@talarian1 talarian1 commented Apr 20, 2023 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR introduces the following new capabilities:

  1. Entitlements service.
  2. GetRemoteFileDetails method - for receiving the remote file checksum information.

@talarian1 talarian1 added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Apr 20, 2023
@talarian1 talarian1 requested a review from eyalbe4 April 20, 2023 15:39
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 20, 2023
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label May 16, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 16, 2023
eyalbe4
eyalbe4 requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should add the new API to the README.
  • The PR title should be mpre generic, and shouldn't reference JFrig CLI specifically.

http/jfroghttpclient/client.go Outdated Show resolved Hide resolved
xray/services/entitlements.go Outdated Show resolved Hide resolved
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label May 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 18, 2023
@talarian1 talarian1 changed the title Support JFrog CLI new dependencies download Add New Entitlement Service May 18, 2023
This was referenced May 18, 2023
Merged
Merged
@talarian1 talarian1 requested a review from eyalbe4 May 19, 2023 14:45
@eyalbe4 eyalbe4 changed the title Add New Entitlement Service New Entitlement Service May 20, 2023
eyalbe4
eyalbe4 requested changes May 20, 2023
View reviewed changes
utils/io/fileutils/files.go Outdated Show resolved Hide resolved
utils/io/fileutils/files.go Outdated Show resolved Hide resolved
@talarian1 talarian1 temporarily deployed to frogbot May 21, 2023 07:38 — with GitHub Actions Inactive
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label May 21, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 21, 2023
@github-actions
Copy link
Contributor

What is Frogbot?

@talarian1 talarian1 temporarily deployed to frogbot May 22, 2023 14:41 — with GitHub Actions Inactive
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label May 22, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 22, 2023
@github-actions
Copy link
Contributor

What is Frogbot?

@talarian1 talarian1 merged commit a6b7149 into jfrog:dev May 22, 2023
19 checks passed
@talarian1 talarian1 deleted the download-cli-dependencies branch May 24, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talarian1 @eyalbe4