Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing specific fields to AQL and fix wrongly asserted close() errors #761

Merged
merged 17 commits into from
Jun 11, 2023
Merged

Support passing specific fields to AQL and fix wrongly asserted close() errors #761

merged 17 commits into from
Jun 11, 2023

Conversation

sarao1310
Copy link
Contributor

@sarao1310 sarao1310 commented May 14, 2023 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@sarao1310 sarao1310 temporarily deployed to frogbot May 14, 2023 19:52 — with GitHub Actions Inactive
@sarao1310 sarao1310 requested a review from eyalbe4 May 15, 2023 08:40
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label May 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 15, 2023
@sarao1310 sarao1310 changed the base branch from master to dev May 15, 2023 08:54
@github-actions
Copy link
Contributor

What is Frogbot?

@sarao1310 sarao1310 added the new feature Automatically generated release notes label May 16, 2023
@sarao1310 sarao1310 requested review from eyalbe4 and removed request for eyalbe4 May 16, 2023 12:27
@sarao1310 sarao1310 temporarily deployed to frogbot May 17, 2023 09:16 — with GitHub Actions Inactive
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label May 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 17, 2023
@github-actions
Copy link
Contributor

What is Frogbot?

@sarao1310 sarao1310 changed the title support include flag in jf search command Support passing specific fields to Aql May 21, 2023
@eyalbe4 eyalbe4 changed the title Support passing specific fields to Aql Support passing specific fields to AQL May 21, 2023
@sarao1310 sarao1310 temporarily deployed to frogbot May 22, 2023 09:49 — with GitHub Actions Inactive
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label May 22, 2023
@github-actions
Copy link
Contributor

What is Frogbot?

@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 22, 2023
@sarao1310 sarao1310 temporarily deployed to frogbot May 22, 2023 10:49 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

What is Frogbot?

@sarao1310 sarao1310 temporarily deployed to frogbot May 22, 2023 13:27 — with GitHub Actions Inactive
@sarao1310 sarao1310 temporarily deployed to frogbot June 2, 2023 19:45 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

What is Frogbot?

@sarao1310 sarao1310 temporarily deployed to frogbot June 4, 2023 15:35 — with GitHub Actions Inactive
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jun 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

What is Frogbot?

@sarao1310 sarao1310 requested a review from sverdlov93 June 6, 2023 10:03
sverdlov93
sverdlov93 reviewed Jun 6, 2023
View reviewed changes
artifactory/services/utils/searchutil.go Outdated Show resolved Hide resolved
artifactory/services/utils/searchutil.go Outdated Show resolved Hide resolved
artifactory/services/utils/searchutil.go Outdated Show resolved Hide resolved
artifactory/services/utils/searchutil.go Outdated Show resolved Hide resolved
artifactory/services/utils/searchutil.go Outdated Show resolved Hide resolved
artifactory/services/utils/searchutil.go Outdated Show resolved Hide resolved
artifactory/services/utils/searchutil.go Outdated Show resolved Hide resolved
artifactory/services/utils/searchutil.go Show resolved Hide resolved
artifactory/services/utils/searchutil.go Outdated Show resolved Hide resolved
@sarao1310 sarao1310 temporarily deployed to frogbot June 6, 2023 14:41 — with GitHub Actions Inactive
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jun 6, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 6, 2023
@sverdlov93 sverdlov93 changed the title Support passing specific fields to AQL Support passing specific fields to AQL and fix wrongly asserted close() errors Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

What is Frogbot?

@sarao1310 sarao1310 temporarily deployed to frogbot June 7, 2023 08:57 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

What is Frogbot?

@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jun 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 7, 2023
@sarao1310 sarao1310 temporarily deployed to frogbot June 11, 2023 13:14 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

What is Frogbot?

@sarao1310 sarao1310 merged commit a3b84a9 into jfrog:dev Jun 11, 2023
4 checks passed
@eyalbe4 eyalbe4 added improvement Automatically generated release notes and removed new feature Automatically generated release notes labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@sverdlov93 sverdlov93 sverdlov93 left review comments

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarao1310 @eyalbe4 @sverdlov93