Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upload progress bar wrong values #778

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Fix upload progress bar wrong values #778

merged 5 commits into from
Jun 14, 2023

Conversation

sarao1310
Copy link
Contributor

@sarao1310 sarao1310 commented Jun 5, 2023 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jun 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 5, 2023
@sarao1310 sarao1310 temporarily deployed to frogbot June 5, 2023 14:38 — with GitHub Actions Inactive
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jun 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 5, 2023
@sarao1310 sarao1310 changed the base branch from master to dev June 5, 2023 14:54
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

What is Frogbot?

@sarao1310 sarao1310 added the bug Something isn't working label Jun 5, 2023
@sarao1310 sarao1310 requested a review from eyalbe4 June 5, 2023 15:01
@sarao1310 sarao1310 changed the title Bug-Fix Bug - CLI upload status bar keep increasing Show correct values in upload progress bar - bug fixing Jun 5, 2023
talarian1
talarian1 reviewed Jun 5, 2023
View reviewed changes
http/httpclient/client.go Outdated Show resolved Hide resolved
utils/io/progress.go Show resolved Hide resolved
@sarao1310 sarao1310 changed the title Show correct values in upload progress bar - bug fixing Fix upload progress bar wrong values - bug fixing Jun 5, 2023
@sarao1310 sarao1310 changed the title Fix upload progress bar wrong values - bug fixing Fix upload progress bar wrong values Jun 5, 2023
@sarao1310 sarao1310 temporarily deployed to frogbot June 5, 2023 15:16 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

What is Frogbot?

@sarao1310 sarao1310 requested review from Or-Geva and removed request for eyalbe4 June 13, 2023 08:16
@sarao1310 sarao1310 temporarily deployed to frogbot June 14, 2023 08:02 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

What is Frogbot?

@sarao1310 sarao1310 temporarily deployed to frogbot June 14, 2023 08:09 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

What is Frogbot?

@sarao1310 sarao1310 merged commit ef833fc into jfrog:dev Jun 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talarian1 talarian1 talarian1 left review comments

@sverdlov93 sverdlov93 sverdlov93 left review comments

@Or-Geva Or-Geva Awaiting requested review from Or-Geva

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarao1310 @talarian1 @sverdlov93