Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New UpdateRepositoryWithParams API #781

Merged
merged 4 commits into from
Jun 8, 2023
Merged

New UpdateRepositoryWithParams API #781

merged 4 commits into from
Jun 8, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jun 7, 2023 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Dependency for jfrog/jfrog-cli-core#822

Add UpdateRepositoryWithParams API, which is working the same way as CreateRepositoryWithParams:

CreateRepositoryWithParams(params interface{}, repoName string) error
UpdateRepositoryWithParams(params interface{}, repoName string) error

I haven't added this in the README because it is not a typical use case. Same as we did in CreateRepositoryWithParams.
Please LMK if you think otherwise.

@yahavi yahavi added the new feature Automatically generated release notes label Jun 7, 2023
@yahavi yahavi requested a review from eyalbe4 June 7, 2023 14:28
@yahavi yahavi self-assigned this Jun 7, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jun 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 7, 2023
@yahavi yahavi marked this pull request as draft June 7, 2023 14:37
@yahavi yahavi marked this pull request as ready for review June 8, 2023 06:13
@yahavi yahavi mentioned this pull request Jun 8, 2023
Merged
4 tasks
RobiNino
RobiNino requested changes Jun 8, 2023
View reviewed changes
artifactory/emptymanager.go Outdated Show resolved Hide resolved
artifactory/services/repositories.go Outdated Show resolved Hide resolved
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jun 8, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 8, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jun 8, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 8, 2023
@yahavi yahavi merged commit 511372c into jfrog:dev Jun 8, 2023
17 of 19 checks passed
@yahavi yahavi deleted the update-repos branch June 8, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobiNino RobiNino RobiNino requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees

@yahavi yahavi

Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yahavi @RobiNino