Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support special characters in build scan parameters #782

Merged
merged 12 commits into from
Jul 3, 2023
Merged

Support special characters in build scan parameters #782

merged 12 commits into from
Jul 3, 2023

Conversation

asafgabai
Copy link
Contributor

@asafgabai asafgabai commented Jun 8, 2023 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Following this issue: jfrog/jfrog-cli#1628
A new REST API was added to Xray that supports special characters in the build-name and build-number parameters.
This API will be used in supporting Xray versions, otherwise, the old API will be used.

@asafgabai asafgabai added the bug Something isn't working label Jun 8, 2023
@asafgabai asafgabai added the safe to test Approve running integration tests on a pull request label Jun 8, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 8, 2023
asafgabai
asafgabai commented Jun 8, 2023
View reviewed changes
xray/services/buildscan.go Outdated Show resolved Hide resolved
@asafgabai asafgabai added the safe to test Approve running integration tests on a pull request label Jun 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 11, 2023
@asafgabai asafgabai marked this pull request as ready for review June 11, 2023 11:26
@asafgabai asafgabai requested a review from eyalbe4 June 11, 2023 11:26
@asafgabai asafgabai added the safe to test Approve running integration tests on a pull request label Jun 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 13, 2023
@asafgabai asafgabai added the safe to test Approve running integration tests on a pull request label Jun 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 13, 2023
@asafgabai asafgabai added the safe to test Approve running integration tests on a pull request label Jun 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 18, 2023
@asafgabai asafgabai added the safe to test Approve running integration tests on a pull request label Jun 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 26, 2023
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jul 2, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 2, 2023
@asafgabai asafgabai temporarily deployed to frogbot July 3, 2023 13:02 — with GitHub Actions Inactive
@asafgabai asafgabai added the safe to test Approve running integration tests on a pull request label Jul 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

@asafgabai asafgabai merged commit 110bf6a into jfrog:dev Jul 3, 2023
19 checks passed
@asafgabai asafgabai deleted the aenkoded-bild-neim-een-bild-skan branch July 3, 2023 13:55
@asafgabai asafgabai mentioned this pull request Jul 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asafgabai @eyalbe4