Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flatten graph to cover node twice when needed. #783

Merged
merged 2 commits into from
Jun 11, 2023
Merged

Fix flatten graph to cover node twice when needed. #783

merged 2 commits into from
Jun 11, 2023

Conversation

asafambar
Copy link
Contributor

@asafambar asafambar commented Jun 11, 2023 •
edited by omerzi

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

omerzi
omerzi approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@omerzi omerzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@omerzi omerzi added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jun 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 11, 2023
@omerzi omerzi merged commit bc2be24 into jfrog:dev Jun 11, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerzi omerzi omerzi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asafambar @omerzi