Flush the Content Writer before closing #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahavi
added
the
safe to test
github-actions
bot
removed
the
safe to test
RobiNino
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable immediate reading of the generated file, it is advisable to flush the Content Writer before closing it. This can be achieved by invoking the Sync() method on the Content Writer file. Once the content is flushed, the writer can be closed using the close() method. Performing these actions in sequence ensures that any buffered content is immediately written to the file, allowing for seamless reading or subsequent operations on the file, such as moving it.
For example, in the following code snippet, we close the Content Writer and then promptly move the file:
https://github.com/jfrog/jfrog-cli-core/blob/v2.35.0/artifactory/commands/transferfiles/errorshandler.go#L244