Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit prepare exclusions pattern function #794

Merged
merged 13 commits into from
Jul 17, 2023
Merged

Edit prepare exclusions pattern function #794

merged 13 commits into from
Jul 17, 2023

Conversation

sarao1310
Copy link
Contributor

@sarao1310 sarao1310 commented Jul 2, 2023 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@sarao1310 sarao1310 temporarily deployed to frogbot July 2, 2023 14:23 — with GitHub Actions Inactive
@sarao1310 sarao1310 changed the title edit patterns exclusions function edit patterns exclusions preparing function Jul 2, 2023
@sarao1310 sarao1310 changed the base branch from master to dev July 2, 2023 19:07
@sarao1310 sarao1310 changed the title edit patterns exclusions preparing function Edit patterns exclusions preparing function Jul 2, 2023
@sarao1310 sarao1310 changed the title Edit patterns exclusions preparing function Edit prepare exclusions pattern function Jul 2, 2023
@sarao1310 sarao1310 added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jul 2, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@sarao1310 sarao1310 temporarily deployed to frogbot July 2, 2023 19:25 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@sarao1310 sarao1310 requested a review from eyalbe4 July 2, 2023 19:27
@sarao1310 sarao1310 temporarily deployed to frogbot July 2, 2023 20:14 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@sarao1310 sarao1310 temporarily deployed to frogbot July 2, 2023 20:42 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jul 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 3, 2023
eyalbe4
eyalbe4 requested changes Jul 3, 2023
View reviewed changes
artifactory/services/fspatterns/utils.go Outdated Show resolved Hide resolved
@sarao1310 sarao1310 temporarily deployed to frogbot July 3, 2023 07:29 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@sarao1310 sarao1310 requested a review from eyalbe4 July 3, 2023 08:48
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jul 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 4, 2023
eyalbe4
eyalbe4 requested changes Jul 4, 2023
View reviewed changes
artifactory/services/fspatterns/utils.go Outdated
// Transform to regexp and prepare Exclude patterns to be used
func PrepareExcludePathPattern(params serviceutils.FileGetter) string {
// Transform to regexp and prepare Exclude patterns to be used, exclusion patterns must be absolute paths.
func PrepareExcludePathPattern(exclusions []string, patternType utils.PatternType, isRecursive bool) (string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isRecursive --> recursive

This function never returned an error, so it probably shouldn't declare it.

This PR seems to be changing nothing except for this function's prototype change. Are you sure this PR is needed? Please reply here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, We now use PrepareExcludePathPattern in the ArchiveProject function in cli-core (that has been called by the GoPublish command), and GoPublishParams does not inherit from FileGetter, so I change the prototype to pass only parameters we really use in PrepareExcludePathPattern.

I'll change the return value.

@sarao1310 sarao1310 temporarily deployed to frogbot July 5, 2023 14:28 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

@sarao1310 sarao1310 temporarily deployed to frogbot July 8, 2023 21:46 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

@sarao1310 sarao1310 temporarily deployed to frogbot July 17, 2023 08:39 — with GitHub Actions Inactive
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 17, 2023
@github-actions
Copy link
Contributor

@sarao1310 sarao1310 merged commit b2e0c7b into jfrog:dev Jul 17, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sarao1310 @eyalbe4