Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic occurs when a build doesn't exist #839

Merged
merged 1 commit into from Oct 4, 2023
Merged

Fix panic occurs when a build doesn't exist #839

merged 1 commit into from Oct 4, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 4, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Follow-up #835

@yahavi yahavi requested a review from sverdlov93 October 4, 2023 09:51
@yahavi yahavi self-assigned this Oct 4, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 4, 2023
@yahavi yahavi added bug Something isn't working safe to test Approve running integration tests on a pull request labels Oct 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 4, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 4, 2023
@yahavi yahavi mentioned this pull request Oct 4, 2023
Closed
4 tasks
@yahavi yahavi merged commit 6efbdf7 into jfrog:dev Oct 4, 2023
18 of 19 checks passed
@yahavi yahavi deleted the fix-no-build branch October 4, 2023 10:40
@yahavi yahavi changed the title Fix panic when build doesn't exist Fix panic occurs when a build doesn't exist Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

Assignees

@yahavi yahavi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yahavi @sverdlov93