Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Pipelines API to give original integrations response without unmarshalling #897

Merged
merged 5 commits into from
Feb 4, 2024
Merged

New Pipelines API to give original integrations response without unmarshalling #897

merged 5 commits into from
Feb 4, 2024

Conversation

bhanurp
Copy link
Collaborator

@bhanurp bhanurp commented Feb 3, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@bhanurp bhanurp requested a review from yahavi February 3, 2024 17:09
@bhanurp bhanurp changed the title Added an API to give original integations response without unmarshalling Added a Pipelines API to give original integrations response without unmarshalling Feb 3, 2024
@bhanurp bhanurp requested a review from eyalbe4 February 3, 2024 17:11
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 3, 2024
eyalbe4
eyalbe4 requested changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add tests for the Get All Integrations API in pipelines_test.go.

README.md Show resolved Hide resolved
@eyalbe4 eyalbe4 self-requested a review February 4, 2024 08:48
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2024
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2024
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2024
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2024
@bhanurp
Copy link
Collaborator Author

bhanurp commented Feb 4, 2024

Let's add tests for the Get All Integrations API in pipelines_test.go.

Added tests for getAllIntegrations

@eyalbe4 eyalbe4 added the new feature Automatically generated release notes label Feb 4, 2024
@eyalbe4 eyalbe4 merged commit d218b0e into jfrog:dev Feb 4, 2024
23 of 24 checks passed
@eyalbe4 eyalbe4 changed the title Added a Pipelines API to give original integrations response without unmarshalling New Pipelines API to give original integrations response without unmarshalling Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi Awaiting requested review from yahavi

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhanurp @eyalbe4 @RobiNino