Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support providing chunk size in multi part upload #936

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Apr 11, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@RobiNino RobiNino added the improvement Automatically generated release notes label Apr 11, 2024
@RobiNino RobiNino requested a review from yahavi April 11, 2024 07:38
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Apr 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 11, 2024
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Let's also add ChunkSize to the README under Uploading Files to Artifactory

@RobiNino RobiNino merged commit 5bf715f into jfrog:dev Apr 24, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants