Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tests #955

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix Tests #955

merged 1 commit into from
May 29, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented May 29, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fix local artifactory tests

  • Change the license check from comparing string to contains
  • Reduce number of retries from 30 to 5 to avoid overhead.

@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label May 29, 2024
@EyalDelarea EyalDelarea requested a review from yahavi May 29, 2024 11:01
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label May 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 29, 2024
@EyalDelarea EyalDelarea merged commit 145a579 into jfrog:dev May 29, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants