Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uploading files with Size filtering and AQL avoiding #963

Merged
merged 70 commits into from
Jul 15, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Jun 16, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

  • Added Sha256 and Size fields to DownloadParams to avoid fetching them with AQL
  • Following this change added support for checksum validation for sha256 and united the checksum validation code.
  • Added SizeThreshold field to support filtering files by size.
  • Improved the ListFiles func, before it was first collecting all files and then running on them again to filter. Now it's filtering the files while collecting them.
  • Also added support for filtering by size threshold.

Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2024
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jun 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 24, 2024
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jul 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 15, 2024
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 merged commit 6351c20 into jfrog:dev Jul 15, 2024
3 of 4 checks passed
@sverdlov93 sverdlov93 added the new feature Automatically generated release notes label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants