Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client ID to usage report #70

Merged
merged 7 commits into from
Mar 7, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Feb 5, 2023

ID is the sha1 on the first mac address found in the machine

@attiasas attiasas added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Feb 5, 2023
@attiasas attiasas requested a review from yahavi February 5, 2023 11:56
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Merging #70 (5cbed87) into master (7d9962d) will increase coverage by 0.18%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   95.63%   95.81%   +0.18%     
==========================================
  Files          15       15              
  Lines         298      311      +13     
  Branches       39       41       +2     
==========================================
+ Hits          285      298      +13     
  Misses         11       11              
  Partials        2        2              
Impacted Files Coverage Δ
src/Artifactory/ArtifactoryClient.ts 100.00% <100.00%> (ø)
src/Artifactory/ArtifactorySystemClient.ts 100.00% <100.00%> (ø)
src/JfrogClient.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/JfrogClient.ts Outdated Show resolved Hide resolved
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 19, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 7, 2023
@attiasas attiasas requested a review from yahavi March 7, 2023 14:39
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 7, 2023
@attiasas attiasas merged commit 0fdde74 into jfrog:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants