-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set timeout #81
Conversation
attiasas
commented
Apr 18, 2023
- Adding option to pass a timeout when creating client
- change default values for timeout and retries
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 95.70% 95.88% +0.17%
==========================================
Files 15 15
Lines 326 340 +14
Branches 48 52 +4
==========================================
+ Hits 312 326 +14
Misses 12 12
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put the "timeout" into this._axiosInstance in the HttpClient constructor? That would remove a lot of code duplication
done |