Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set timeout #81

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Conversation

attiasas
Copy link
Contributor

  1. Adding option to pass a timeout when creating client
  2. change default values for timeout and retries

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Apr 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 18, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Apr 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 18, 2023
@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Apr 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 18, 2023
@attiasas attiasas requested review from yahavi and Or-Geva April 18, 2023 08:00
@codecov-commenter
Copy link

Codecov Report

Merging #81 (653ed5e) into master (4faae22) will increase coverage by 0.17%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   95.70%   95.88%   +0.17%     
==========================================
  Files          15       15              
  Lines         326      340      +14     
  Branches       48       52       +4     
==========================================
+ Hits          312      326      +14     
  Misses         12       12              
  Partials        2        2              
Impacted Files Coverage Δ
src/Artifactory/ArtifactoryClient.ts 100.00% <100.00%> (ø)
src/Artifactory/ArtifactoryDownloadClient.ts 97.14% <100.00%> (+0.26%) ⬆️
src/Artifactory/ArtifactorySystemClient.ts 100.00% <100.00%> (ø)
src/HttpClient.ts 98.36% <100.00%> (ø)
src/Xray/XrayClient.ts 100.00% <100.00%> (ø)
src/Xray/XrayEntitlementsClient.ts 100.00% <100.00%> (ø)
src/Xray/XraySystemClient.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put the "timeout" into this._axiosInstance in the HttpClient constructor? That would remove a lot of code duplication

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Apr 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 19, 2023
@attiasas
Copy link
Contributor Author

Can we put the "timeout" into this._axiosInstance in the HttpClient constructor? That would remove a lot of code duplication

done

@attiasas attiasas closed this Apr 19, 2023
@attiasas attiasas reopened this Apr 19, 2023
@attiasas attiasas merged commit b47c545 into jfrog:master Apr 19, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants