Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when reading results from cache #404

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

talarian1
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

The following Null Pointer Exception was thrown as a result of changing the FileIssueNode data object without updating the cache version:

com.intellij.diagnostic.PluginException: annotator: com.jfrog.ide.idea.inspections.JFrogSecurityAnnotator@7515b1ba (class com.jfrog.ide.idea.inspections.JFrogSecurityAnnotator) [Plugin: org.jfrog.idea]
 at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
 at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:89)
 at com.intellij.codeInsight.daemon.impl.ExternalToolPass.processError(ExternalToolPass.java:251)
 at com.intellij.codeInsight.daemon.impl.ExternalToolPass.doApply(ExternalToolPass.java:227)
 at com.intellij.codeInsight.daemon.impl.ExternalToolPass.doApply(ExternalToolPass.java:216)
 at com.intellij.codeInsight.daemon.impl.ExternalToolPass$1.lambda$run$1(ExternalToolPass.java:168)
 at com.intellij.openapi.application.ReadAction.lambda$run$1(ReadAction.java:64)
 at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:923)
 at com.intellij.openapi.application.ReadAction.compute(ReadAction.java:76)
 at com.intellij.openapi.application.ReadAction.run(ReadAction.java:63)
...
Caused by: java.lang.NullPointerException: Cannot invoke "com.jfrog.ide.common.nodes.subentities.FindingInfo.getRowStart()" because "this.findingInfo" is null

@talarian1 talarian1 added the bug Something isn't working label Aug 23, 2023
@talarian1 talarian1 marked this pull request as ready for review August 23, 2023 15:40
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Aug 23, 2023
@talarian1 talarian1 merged commit 6542258 into jfrog:master Aug 23, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working safe to test Approve running integration tests on a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants