Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only one thread to update the AnalyzerManager binary at any time #410

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

talarian1
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Due to the addition of multiple scanners that use the same binary (AnalyzerManager) to scan the project. It is possible that more than one scanner will initiate the binary download flow which may cause one of the multiple scans to fail.
This PR suggests limiting the number of possible download attempts to 1.

@talarian1 talarian1 added bug Something isn't working safe to test Approve running integration tests on a pull request labels Aug 28, 2023
@talarian1 talarian1 requested a review from eyalbe4 August 28, 2023 14:17
@talarian1 talarian1 merged commit 90146c4 into jfrog:master Aug 31, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working safe to test Approve running integration tests on a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants