Add Support to the New Scanners Config #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalbe4
requested changes
Sep 11, 2023
src/main/java/com/jfrog/ide/idea/scan/SourceCodeScannerManager.java
Outdated
Show resolved
Hide resolved
yahavi
suggested changes
Oct 1, 2023
| } | ||
|
|
||
| protected List<JFrogSecurityWarning> execute(ScanConfig.Builder inputFileBuilder, List<String> args, Runnable checkCanceled, boolean createInputFile, File executionDir) throws IOException, InterruptedException { | ||
| protected List<JFrogSecurityWarning> execute(ScanConfig.Builder inputFileBuilder, List<String> args, Runnable checkCanceled, boolean newConfigFormat) throws IOException, InterruptedException { |
There was a problem hiding this comment.
This method became very long and not readable. Please consider refactoring by splitting it into submethods in this or another PR.
| @@ -288,7 +287,7 @@ protected void downloadBinary() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| Path createTempRunInputFile(ScansConfig scanInput) throws IOException { | |||
| Path createTempRunInputFile(Object scanInput) throws IOException { | |||
There was a problem hiding this comment.
Deserializing an object is considered insecure. See https://owasp.org/www-project-top-ten/2017/A8_2017-Insecure_Deserialization.
Let's deserialize only ScanConfig or NewScanConfig. You can use method overloading for this.
There was a problem hiding this comment.
Those are internal input objects that should be unified in the near future (when all the scanners will support the new config file). Hence we are only deserializing objects we are creating, I see no security concern here.
src/main/java/com/jfrog/ide/idea/scan/SourceCodeScannerManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/scan/SourceCodeScannerManager.java
Outdated
Show resolved
Hide resolved
| JFrogApplicationsConfig projectConfig = parseJFrogApplicationsConfig(); | ||
|
|
||
| if (projectConfig != null) { | ||
| for (ModuleConfig moduleConfig : projectConfig.getModules()) { |
There was a problem hiding this comment.
Can we run them in tasks? Running each scanner serially may take a lot of time
There was a problem hiding this comment.
We should do it in a separate PR in the near future.
talarian1
force-pushed
the
new-scanners-config
branch
from
99681d9
to
7c8ee3a
Compare
talarian1
added
the
safe to test
talarian1
added
safe to test
yahavi
suggested changes
Oct 5, 2023
src/main/java/com/jfrog/ide/idea/scan/data/applications/JFrogApplicationsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/scan/data/applications/JFrogApplicationsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/scan/data/applications/JFrogApplicationsConfig.java
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/scan/data/applications/ModuleConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/scan/data/applications/ModuleConfig.java
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/scan/data/applications/ScannerConfig.java
Outdated
Show resolved
Hide resolved
talarian1
added
improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the new project config file.
Depends on jfrog/ide-plugins-common#134