Scan all available roots when no configuration file can be found by JAS scanners #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or-Geva
added
bug
github-actions
bot
removed
the
safe to test
yahavi
suggested changes
Nov 14, 2023
src/main/java/com/jfrog/ide/idea/scan/data/applications/JFrogApplicationsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/scan/data/applications/JFrogApplicationsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/scan/data/applications/JFrogApplicationsConfig.java
Show resolved
Hide resolved
| @@ -97,8 +95,8 @@ public void startScan() { | |||
| scanner.asyncScanAndUpdateResults(); | |||
| } | |||
| executor.shutdown(); | |||
| if (!executor.awaitTermination(SCAN_TIMEOUT_MINUTES, TimeUnit.MINUTES)) { | |||
| logError(Logger.getInstance(), "Scan timeout of " + SCAN_TIMEOUT_MINUTES + " minutes elapsed. The scan is being canceled.", true); | |||
| if (!executor.awaitTermination(Long.MAX_VALUE, TimeUnit.MINUTES)) { | |||
There was a problem hiding this comment.
I disagree with that approach. In a developer environment, it's better to end the scan after a few minutes. Plus, users don't get any feedback or indication about the ongoing scan during this prolonged period. But ultimately, it's up to you to decide.
There was a problem hiding this comment.
We will remove the timeout, add more logging, and add progress bars to enhance the user experience as discussed on Zoom
This reverts commit 7b5f760.
1 task
Or-Geva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves an issue in the JAS scanners. Previously, in the absence of a configuration file, the scanners would only scan the root project of the opened workspace. This fix ensures that when no configuration is available, the scanners will now comprehensively scan all roots detected by IDEA.