Yarn - Refactor the process of building impact graph #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
noyshabtay
commented
Nov 19, 2023
•
noyshabtay
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- Depends on Resolved Yarn 1 impact graph issue displaying hoisted paths ide-plugins-common#144
- note to change settings.gradle & build.gradle before merge
- addImpactPathToDependencyNode increment logic was fixed in ScannerBase.java
- walkDepTree new logic using 'Yarn why' command was added using YarnScanner.java
- YarnScanerTests.java was added with new resources in yarn.exampleYarnProject dir
# Conflicts: # src/main/java/com/jfrog/ide/idea/scan/ScannerBase.java
noyshabtay
added
bug
github-actions
bot
removed
the
safe to test
noyshabtay
added
the
safe to test
github-actions
bot
removed
the
safe to test
noyshabtay
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
suggested changes
Nov 23, 2023
src/main/java/com/jfrog/ide/idea/scan/SingleDescriptorScanner.java
Outdated
Show resolved
Hide resolved
src/test/resources/yarn/exampleYarnPackage/__tests__/area-rectangle-test.js
Outdated
Show resolved
Hide resolved
…of not-complete dependency tree
yahavi
suggested changes
Nov 23, 2023
Or-Geva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.