Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Verification Code for SSO Login #450

Merged
merged 7 commits into from
Dec 11, 2023

Conversation

noyshabtay
Copy link
Contributor

@noyshabtay noyshabtay commented Dec 11, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

  • Verification code added to SSO login process.

@noyshabtay noyshabtay added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Dec 11, 2023
@noyshabtay noyshabtay self-assigned this Dec 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 11, 2023
@Or-Geva Or-Geva requested a review from yahavi December 11, 2023 09:44
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that:

  1. Nothing moves after clicking on a button
  2. The code is copyable

@noyshabtay noyshabtay merged commit 6acdbbb into jfrog:master Dec 11, 2023
9 checks passed
@noyshabtay noyshabtay deleted the sso-issue branch December 11, 2023 13:30
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants