Remove timeout from advanced security scan #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
requested changes
Nov 23, 2023
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
requested changes
Nov 29, 2023
| */ | ||
| private static cancelProcess(childProcess: exec.ChildProcess, checkCancel: () => void, reject: (reason?: any) => void): void { | ||
| try { | ||
| checkCancel(); |
There was a problem hiding this comment.
You already kill the process. Why running checkCancel?
Moreover - I think that running checkCancel without killing the process may end with a Zombie process.
There was a problem hiding this comment.
It assesses whether a cancellation has been requested. If a cancellation is detected, it proceeds to send a termination signal to the child process.
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.