Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secrets integration tests after AM v1.7.0 #476

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Jun 6, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

In AnalyzerManager v1.7.0+ the name of the rule-id of an expected secret scan issue was changed.
source -> REQ.SECRET.GENERIC.CODE
Breaking the test. changing to new value

@attiasas attiasas added the ignore for release Automatically generated release notes label Jun 6, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 6, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 6, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit d2acc5a into jfrog:master Jun 13, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants