Fix access log regex to match input #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhung
reviewed
Apr 10, 2024
fluent_metrics.conf.rt
Outdated
| @@ -422,7 +422,7 @@ | |||
| tag jfrog.rt.artifactory.access | |||
| <parse> | |||
| @type regexp | |||
| expression /^(?<timestamp>[^ ]*) \[(?<trace_id>[^\]]*)\] \[(?<action_response>[^\]]*)\] (?<repo_path>.*) for client : (?<username>.+)/(?<ip>.+)\.$/m | |||
| expression /^(?<timestamp>[^\s]*) \[(?<trace_id>[^\]\s]*)\] \[(?<action_response>[^\]\r\n]*)\] (?<repo_path>[^\s]*)? *for client : *(?<username>[^\s]*) *\/ *(?<ip>[^\s]*)?[\.\s]?(\[(?<token>[^\s]*)\])?$/m | |||
There was a problem hiding this comment.
Not a blocker. Just a suggestion for future. In previous job where lots of regexes were used, we had a team rule that any regex must be accompanied by examples of string that the regex tries to match, as well as comprehensive tests. Obviously tests aren't possible here but I think examples here would help future us.
There was a problem hiding this comment.
great point. I'll add some examples
alexhung
approved these changes
Apr 10, 2024
alexhung
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a log regex in fluentd config for the artifactory-access.log file, to match a change in the input log