Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android samples use old gradle plugins, updating breaks samples #28

Closed
remydavid opened this issue Jan 25, 2016 · 4 comments
Closed

Android samples use old gradle plugins, updating breaks samples #28

remydavid opened this issue Jan 25, 2016 · 4 comments

Comments

@remydavid
Copy link

This sample :
https://github.com/JFrogDev/project-examples/blob/master/gradle-examples/4/gradle-android-aar/build.gradle

Uses :
'com.android.tools.build:gradle:0.9.2'
'com.github.dcendents:android-maven-plugin:1.0'

Android gradle plugin v0.9.2 is very old and not compatible with the latest Android Studio versions, current is 1.5.0.
Also, android-maven-plugin latest version is 1.3.
Updating one or the other breaks the sample.

@remydavid remydavid changed the title Android samples use old gradle plugins, updating break samples Android samples use old gradle plugins, updating breaks samples Jan 25, 2016
@eyalbe4
Copy link
Contributor

eyalbe4 commented Jan 25, 2016

Thanks you for this @remydavid.
Would you be able to contribute and submit a pull request with these changes?

@noamtamim
Copy link

+1
Please update the sample. I can't get it to work.

Manabu-GT added a commit to Manabu-GT/project-examples that referenced this issue Apr 19, 2016
@Manabu-GT
Copy link
Contributor

@noamtamim you can look at Manabu-GT@e44d967 if you are still having the issue to make it work.

eyalbe4 added a commit that referenced this issue Apr 20, 2016
update android sample to use latest tools/plugins which solves #28
@eyalbe4
Copy link
Contributor

eyalbe4 commented Apr 20, 2016

@Manabu-GT 's pull request was merged. Thanks @Manabu-GT !

@eyalbe4 eyalbe4 closed this as completed Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants