Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authentication flows #122

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Fix authentication flows #122

merged 3 commits into from
Jan 18, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jan 18, 2024 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Fix #121

  • Fix anonymous access
  • Fix authentication with username + access token
  • When there are no credentials provided, allow at least downloading the CLI
  • Fix integration test to run search command instead of ping, because ping is allowed without credentials
  • Make the integration test run on forks, if credentials provided

@yahavi yahavi self-assigned this Jan 18, 2024
@yahavi yahavi added the bug Something isn't working label Jan 18, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jan 18, 2024
@yahavi yahavi added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Jan 18, 2024
sverdlov93
sverdlov93 reviewed Jan 18, 2024
View reviewed changes
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Show resolved Hide resolved
eyalbe4
eyalbe4 requested changes Jan 18, 2024
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
sverdlov93
sverdlov93 reviewed Jan 18, 2024
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
@yahavi yahavi merged commit 69c1043 into jfrog:master Jan 18, 2024
10 of 11 checks passed
@yahavi yahavi deleted the fix-credentials branch January 18, 2024 13:27
@yahavi yahavi mentioned this pull request Jan 18, 2024
Closed
@yahavi yahavi linked an issue Jan 18, 2024 that may be closed by this pull request
Exchanging JSON web token with an access token failed: Input required and not supplied: oidc-provider-name jfrog/jfrog-cli#2418
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

@eyalbe4 eyalbe4 eyalbe4 requested changes

@eranturgeman eranturgeman Awaiting requested review from eranturgeman

Assignees

@yahavi yahavi

Labels
bug Something isn't working safe to test Approve running integration tests on a pull request
Projects
None yet
Milestone
No milestone
3 participants
@yahavi @eyalbe4 @sverdlov93