Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the cleanup script to use the tool cache #124

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jan 18, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Fix #120

In the cleanup stage, use JFrog CLI from the cache and avoid downloading it. Before this pull request, we downloaded the JFrog CLI when the version was set to "latest".

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jan 18, 2024
@yahavi yahavi marked this pull request as ready for review January 18, 2024 16:25
@yahavi yahavi self-assigned this Jan 18, 2024
src/utils.ts Outdated Show resolved Hide resolved
@yahavi yahavi merged commit 674f39c into jfrog:master Jan 18, 2024
10 of 11 checks passed
@yahavi yahavi deleted the fix-cleanup branch January 18, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working safe to test Approve running integration tests on a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JFrog CLI not reading environment variables correctly
2 participants