Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming repository #80

Closed
alexhung opened this issue Apr 24, 2023 · 4 comments · Fixed by #101
Closed

Renaming repository #80

alexhung opened this issue Apr 24, 2023 · 4 comments · Fixed by #101
Assignees
Labels
enhancement New feature or request

Comments

@alexhung
Copy link
Member

alexhung commented Apr 24, 2023

Rename this repository from artifactory-secrets-plugin to vault-plugin-secrets-artifactory, following the same pattern as other Vault plugin repos (as well as Terraform provider).

Other references to the original name (binary name, path, etc.) would not be affected by this repo name change.

@alexhung alexhung self-assigned this Apr 24, 2023
@alexhung alexhung added the enhancement New feature or request label Apr 24, 2023
@TJM
Copy link
Contributor

TJM commented Apr 24, 2023

AGREED!!!

@TJM
Copy link
Contributor

TJM commented Apr 24, 2023

Based on what I am seeing at hashicorp, it should be

vault-plugin-secrets-artifactory

So, "secrets" instead of "secret" ... but yes, I think it would make good sense to do this BEFORE going 1.0.0 ;)

@alexhung
Copy link
Member Author

The reason I chose singular form is because when you do vault plugin list you get:

redis-elasticache-database-plugin    database    v0.1.0+builtin
redshift-database-plugin             database    v1.12.2+builtin.vault
snowflake-database-plugin            database    v0.6.1+builtin
ad                                   secret      v0.14.0+builtin
alicloud                             secret      v0.13.0+builtin
artifactory-secrets-plugin           secret      v0.2.17-dev+c28e2f9

So the type is secret but I just noticed that HashiCorp's repo is plural: https://github.com/hashicorp/vault-plugin-secrets-kv

@TJM
Copy link
Contributor

TJM commented Apr 25, 2023

I am sure it's good either way, one other thing to remember would be to update the integrations page:

https://developer.hashicorp.com/vault/integrations?filter=artifactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants