Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use env variables during make setup #37

Merged
merged 1 commit into from
Feb 22, 2023
Merged

feat: use env variables during make setup #37

merged 1 commit into from
Feb 22, 2023

Conversation

TJM
Copy link
Contributor

@TJM TJM commented Feb 22, 2023

This just allows you to set useful environment variables like ARTIFACTORY_URL and ACCESS_TOKEN to allow make setup to work.

@TJM TJM requested a review from alexhung as a code owner February 22, 2023 15:58
@TJM TJM mentioned this pull request Feb 22, 2023
Closed
alexhung
alexhung approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@alexhung alexhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll update CHANGELOG and do a release.

Turhsus
Turhsus approved these changes Feb 22, 2023
View reviewed changes
Copy link

@Turhsus Turhsus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexhung alexhung merged commit a540732 into jfrog:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhung alexhung alexhung approved these changes

@Turhsus Turhsus Turhsus approved these changes

@shrajfr12 shrajfr12 shrajfr12 approved these changes

@MahithaB MahithaB Awaiting requested review from MahithaB

@mritunjaykumar mritunjaykumar Awaiting requested review from mritunjaykumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TJM @alexhung @Turhsus @shrajfr12