More makefile fixes

[TJM]

I noticed that make upgrade was not working. I also noticed that the plugin name was "artifactory-secrets-plugin" instead of "artifactory" so I tried to work on that.

• Makefile variables that are static should use :=, especially ones that use shell commands to evaluate
• consistent interpolation, I think Makefile recommends using $(VAR_NAME) (rather than curly braces which can sometimes be mistaken for shell variables)
• make register - only register
• make upgrade (add build that was part of register)
• update PHONY
• Set PLUGIN_NAME separately from PLUGIN_FILE (to prevent future filename changes from affecting as much)
• make plugin name artifactory (instead of artifactory-secrets-engine)
• Make the "dev/test" procedure more closely match the intended use case (README)
• make setup needs to register (if plugin name is artifactory)

[TJM]

I was thinking of adding something like:

GIT_DIRTY := $(shell test -n "`git status --porcelain`" && echo "+CHANGES" || true)

... and add it to the version string, but the git commit hash is already behind a +, so it causes an error, due to it not being a semantic version. We could do "-CHANGES" but... (see thread on make upgrade)

~tommy

[alexhung]

This should remain PLUGIN_PATH.

The Vault help doc clearly use 'path' for vault secrets enable/disable command.

Usage: vault secrets disable [options] PATH

Whereas it uses 'name' (synonymous with file name here) for vault plugin ... commands.

Usage: vault plugin register [options] TYPE NAME

[TJM]

"enable" should use the registered plugin name

[alexhung]

Just so happened that both PLUGIN_PATH and PLUGIN_NAME have same value ('artifactory'). I'm ok with using PLUGIN_NAME. May be rename PLUGIN_PATH to PLUGIN_FILE_PATH to reduce confusion?

[TJM]

or maybe PLUGIN_VAULT_PATH ?

[TJM]

If you have a better idea for this, I am open to it. I did have a case where I was trying to test on a "real" vault server (not the dev one) and I wanted to use something like test-artifactory... so I had already started this change for $(PLUGIN_PATH), but I agree that it is confusing, so PLUGIN_VAULT_PATH or VAULT_PLUGIN_PATH or ????

[alexhung]

I'll review/approve this PR once you are ready and toggle this from 'Draft' 😄

[TJM]

Rebased to cut the number of "fix" commits down, this should be ready to go.