Allow for multiple smoothie configurations #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2016
|
Thanks for the pull request, will review this soon! |
stephenmoloney
force-pushed
the
multiple-smoothies
branch
from
3b35907
to
a8608a3
Compare
|
cheers. |
|
I am doing some major refactorings that support these use-cases. Simplified the API a bit, and added tests... Work in progress |
|
Refactored the pull request to facilitate slightly different API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem 1:
Currently only one smoothie configuration is possible, this PR allows for more than one.
Problem 2:
Sometimes a layout might not be desired, this PR allows the options
mix smoothie.compile --no-layoutand the template will not be embedded in the layout.Feature Request 3:
Foundation-emails makes email great and easy... add
foundation-emailto npm repos and allow the use of inky templating. This is an optional feature and is only activate when passed as a parameter...mix smoothie.compile --foundation_See companion PR in the
elixir-smoothielibrary_jfrolich/elixir-smoothie#2