Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Plugin multi-event compatible #1

Closed
jfwiebe opened this issue Nov 7, 2017 · 4 comments
Closed

Make Plugin multi-event compatible #1

jfwiebe opened this issue Nov 7, 2017 · 4 comments

Comments

@jfwiebe
Copy link
Owner

jfwiebe commented Nov 7, 2017

Currently, the plugin is only able to show the shop of one event within a WordPress instance. It would be great to have multiple shops within one site.
@raphaelm
Copy link
Collaborator

raphaelm commented Nov 7, 2017

Thanks for making this! Yes, this would be great, as the widget is especially interesting for users with lots of events who have some kind of calendar on their website.

You could just reduce the settings to the JS and CSS links and have the event link as an argument to the shortcode, this would be an easy and powerful solution.

@jfwiebe
Copy link
Owner Author

jfwiebe commented Nov 8, 2017

@raphaelm That is a great idea!

Two questions came into my mind:

  1. The CSS is event specific because of the event color, isn't it? I can not select another file for the <head> area because it is already processed before the shortcode is evaluated.
  2. The JS link is language-specific which should ideally be selected based on the viewers language but it is not clear which languages are supported by the event. Or: de-informal-JS-File is globally used, but one of the events has no de-informal texts, how to deal with that?

Do you have an idea for that?
Thanks & with best regards
JF

@raphaelm
Copy link
Collaborator

raphaelm commented Nov 8, 2017

The CSS is event specific because of the event color, isn't it? I can not select another file for the area because it is already processed before the shortcode is evaluated.

Yes, it currently is only the color. I think it is fine if one needs to decide for one color for all widgets within one WordPress instance.

Or: de-informal-JS-File is globally used, but one of the events has no de-informal texts, how to deal with that?

The built-in strings of the widget ("Add to cart") will still be de-informal, all other strings will be in any or the primary language of the event, I haven't tested it. I also think that is fine to have as collateral damage, if people really use events with different languages in their blog.

jfwiebe added a commit that referenced this issue Nov 8, 2017
@jfwiebe
#1 Added Multi-Event Capability
6b492bd
jfwiebe added a commit that referenced this issue Nov 8, 2017
@jfwiebe
#1 add notice on global css and js file usage
0dd7494
@jfwiebe
Copy link
Owner Author

jfwiebe commented Nov 8, 2017

implemented via 6b492bd and 0dd7494.

@jfwiebe jfwiebe closed this as completed Nov 8, 2017
@jfwiebe jfwiebe mentioned this issue Mar 8, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raphaelm @jfwiebe