Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update slider dark and light FD style colors. #26

Open
MairwunNx opened this issue Dec 24, 2018 · 9 comments
Open

Please update slider dark and light FD style colors. #26

MairwunNx opened this issue Dec 24, 2018 · 9 comments

Comments

@MairwunNx
Copy link
Contributor

MairwunNx commented Dec 24, 2018

Hello! I re-write it text 3 times! Because google crash it page! It so not cool!

Please, review it issue and commit changes, i change dark and light colors of slider to FD style and fixed slider line focus.


Bug (Not-Excepted behavior of slider line):

sliderlineissue

Excepted behavior of slider line:

sliderlineexpected


COLOR CHANGES


Unselected state for dark theme:

unselecteddarkslider

Pressed state for dark theme:

presseddarkslider


Unselected state for light theme:

unselecredslider

Pressed state for light theme:

pressedslider


Code for JMetroBase.css file: view

Code for JMetroLightTheme.css file: view

Code for JMetroDarkTheme.css file: view

@MairwunNx
Copy link
Contributor Author

I know that is issue is great or big. Sorry, in next time i try create issues content most shorten.

@MairwunNx MairwunNx changed the title Please update slider dark and light style colors and bug with slider line focus. Please update slider dark and light FD style colors. Dec 24, 2018
@dukke
Copy link
Member

dukke commented Dec 24, 2018

So you're issue here is that while the slider thumb is being dragged and you mouse hover the "slider line" the "slider line" color shouldn't change? And in JMetro the "Slider line" color is changing while doing this?

Thanks!

@MairwunNx
Copy link
Contributor Author

Issue in slider colors and slider hovering on slider line. No problem.

@dukke
Copy link
Member

dukke commented Dec 24, 2018

When slider thumb is being dragged? And the issue is only with the slider line?

@MairwunNx
Copy link
Contributor Author

When slider thumb is being dragged and you lost focus on slider line.

Consider gif with issue carefully :), i dragged thumb and lost focus of slider line))

@dukke
Copy link
Member

dukke commented Dec 24, 2018

OK, just to make sure I get exactly what the issue is all about: the colors that aren't correct are the colors of the "slider line" only?

@MairwunNx
Copy link
Contributor Author

Just, what i do:

Changed slider colors, if i'm not mistaken, color changes have been applied on slider line.
Because i changed colors to FD style specifications fixed small bug with lost focus line.

@dukke
Copy link
Member

dukke commented Dec 24, 2018

OK thanks 👍

@MairwunNx
Copy link
Contributor Author

MairwunNx commented Dec 24, 2018

No problem @dukke :) contributing with ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants