Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses id on element if exists. #35

Merged
merged 2 commits into from May 20, 2014
Merged

Uses id on element if exists. #35

merged 2 commits into from May 20, 2014

Conversation

dawnerd
Copy link
Collaborator

@dawnerd dawnerd commented May 19, 2014

This functionality can be overridden by providing a custom anchorName() filter.

This functionality can be overridden by providing a custom anchorName() filter.
@@ -96,6 +96,10 @@ jQuery.fn.toc.defaults = {
highlightOnScroll: true,
highlightOffset: 100,
anchorName: function(i, heading, prefix) {
if(heading.id.length) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't stop the span from being created

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh doh! Didn't even see the span.

@dawnerd dawnerd mentioned this pull request May 19, 2014
jgallen23 added a commit that referenced this pull request May 20, 2014
@jgallen23 jgallen23 merged commit fbe3f85 into master May 20, 2014
@jgallen23 jgallen23 deleted the feature/tweaks branch May 20, 2014 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants