This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
univalue optimizations: move semantics, reduce temporary strings #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introducing move semantics for pushKV and push_back. In many use cases the const& calls unnecessarily create a copy of the argument, when objects can be moved this does not happen. * Reduce creation of temporary strings. `json_escape` and `write` now appends to an existing string instead of creating a temporary. * Use `std::to_string` instead of `std::ostringstream` for `setNumStr`, which is much faster than creating a temporary string. In a benchmark with Bitcoin's BlockToJsonVerbose, using these move methods where possible speeds up JSON generation by about a factor of 2.
When known that it is just a char that's appended, use character instead of a string. This can use a different overload in std::string, which is faster.
|
Closing the PR due to zero interest in the last 8 months. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing move semantics for pushKV and push_back. In many use cases
the const& calls unnecessarily create a copy of the argument, when
objects can be moved this does not happen.
Reduce creation of temporary strings.
json_escapeandwritenowappends to an existing string instead of creating a temporary.
Use
std::to_stringinstead ofstd::ostringstreamforsetNumStr,which is much faster than creating a temporary string.
In a benchmark with Bitcoin's BlockToJsonVerbose, using these move
methods where possible speeds up JSON generation by about a factor of 2.
You can see some benchmarks here: bitcoin/bitcoin#20999