Support wrapping optional around primalize
#6
Conversation
Prior to this change, nesting `optional(primalize(FooSerializer))` would properly handle `nil` values, but would directly coerce the passed object as JSON rather than calling the specified serializer. This change updates to call the nested primalize serializer with the object.
There was a problem hiding this comment.
Thanks! I remember having an issue composing modifiers with primalize (and I think optional was the one I was using), but I ended up working around it and never revisited it.
I'll be honest that I don't deeply understand all the functionality at play here so this solution is largely pattern matching on some of the other implementations, notably the
Arraycoercion logic, but thankfully the test suite had solid coverage and helped point me in the correct direction, so functionally I think this is good, but happy to adjust implementation however might make sense.
This looks right to me, too. The modifiers can be a little tricky, which is probably why I overlooked this.
|
Also released v0.3.10 with this change |
|
Thanks for the quick pickup, and again, thanks for the great library! |
Prior to this change, nesting
optional(primalize(FooSerializer))would properly handlenilvalues, but would directly coerce the passed object as JSON rather than calling the specified serializer.This change updates to call the nested primalize serializer with the object.
I'll be honest that I don't deeply understand all the functionality at play here so this solution is largely pattern matching on some of the other implementations, notably the
Arraycoercion logic, but thankfully the test suite had solid coverage and helped point me in the correct direction, so functionally I think this is good, but happy to adjust implementation however might make sense.