Support wrapping optional
around primalize
#6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, nesting
optional(primalize(FooSerializer))
would properly handlenil
values, but would directly coerce the passed object as JSON rather than calling the specified serializer.This change updates to call the nested primalize serializer with the object.
I'll be honest that I don't deeply understand all the functionality at play here so this solution is largely pattern matching on some of the other implementations, notably the
Array
coercion logic, but thankfully the test suite had solid coverage and helped point me in the correct direction, so functionally I think this is good, but happy to adjust implementation however might make sense.