Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for update to MVC5 and AppVeyor #50

Closed
omarpiani opened this issue Nov 2, 2016 · 3 comments
Closed

Pull request for update to MVC5 and AppVeyor #50

omarpiani opened this issue Nov 2, 2016 · 3 comments

Comments

@omarpiani
Copy link
Contributor

omarpiani commented Nov 2, 2016

Hi @jgauffin !
I successfully updated, compiled and runned and tested your project in my fork with VS2015, MVC5 and .NET Framework 4.5.2.

Admin backend at the moment have some issues caused by MVC3 template.

Project is forked here
https://github.com/omarpiani/griffin.mvccontrib

it will be awesome to use CI of appveyor for new releases of this package.
For example https://ci.appveyor.com/project/fiorebat/griffin-mvccontrib/build/1.0.5 builds, test requiring SQLExpress are failing, but I will replace them with LocalDB

Are you still available for an hot pull in this project?

Regards

@jgauffin
Copy link
Owner

jgauffin commented Nov 2, 2016

yes. A pull request is most welcome.

@omarpiani omarpiani changed the title Pull request for update this project? Pull request for update to MV5 and AppVeyor Nov 3, 2016
@omarpiani
Copy link
Contributor Author

PR was sent.
I suggest to setup this project in appveyor https://www.appveyor.com/ for CI! It's free for OpenSource and take few minutes

Add the SQLServer2014 service and place this Powershell configuration before build

$startPath = $env:APPVEYOR_BUILD_FOLDER
$config = join-path $startPath "source\Griffin.MvcContrib.SqlServer.Tests\app.config"
$doc = (gc $config) -as [xml]
$doc.SelectSingleNode('//connectionStrings/add[@name="DefaultConnection"]').connectionString = 'Server=(local)\SQL2014;Database=GriffinMvcContribSQLTest;User ID=sa;Password=Password12!'
$doc.SelectSingleNode('//connectionStrings/add[@name="SetupConnection"]').connectionString = 'Server=(local)\SQL2014;Database=master;User ID=sa;Password=Password12!'
$doc.Save($config)

cd source
nuget restore

Next step can be AppVeyor can help you to publish new version of nuget packages, never tried, but seems fantastic

@omarpiani omarpiani changed the title Pull request for update to MV5 and AppVeyor Pull request for update to MVC5 and AppVeyor Nov 3, 2016
@jgauffin
Copy link
Owner

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants