Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages not marked as read with telepathy-haze #144

Closed
nodevel opened this issue Sep 21, 2015 · 12 comments
Closed

Messages not marked as read with telepathy-haze #144

nodevel opened this issue Sep 21, 2015 · 12 comments

Comments

@nodevel
Copy link

nodevel commented Sep 21, 2015

Hi,

I am trying to use your plugin (great work, by the way) on telepathy, through the telepathy-haze layer, in order to have Facebook Messenger integrated on SailfishOS ( https://openrepos.net/content/nodevel/facebook-messenger-account ). Messages work well - can be sent and received - but there is one annoying problem: Messages are not be marked as read on the server, therefore they are being received over and over again on every reconnection.

Is there any way to mark messages read by default, as soon as they are received by the plugin?

I know that telepathy-haze in most likely not among supported solutions, but I don't understand why it should work any different, if message receiving already works.

I have tried two last releases (6a0a79182ebc, 5727ffb502c7) with the same outcome.

Thank you.

@jgeboski
Copy link
Collaborator

Is there any way to mark messages read by default, as soon as they are received by the plugin?

It use to be done this way, then users wanted it done on conversation focus (#80). Now users want it done when a message is sent in response (#118). I will eventually have to make this more configurable.

I know that telepathy-haze in most likely not among supported solutions, but I don't understand why it should work any different, if message receiving already works.

It needs to support the conversation-updated signal, the deleting-conversation signal, and purple_conversation_has_focus(). I was initially hesitant doing this as I figured people who were not using pidgin or finch, would run into this issue.

@MoritzJT
Copy link

Would be nice if we had the opportunity to configure this in the plugin settings lateron @nodevel
I imagine some users want it done manually, some want the read status prevented alltogether etc...

@nodevel
Copy link
Author

nodevel commented Sep 21, 2015

@jgeboski Thanks for your reply!

I see, so the current behavior is that it marks messages as read when you reply to the thread?

If I wanted to change that behavior (to the one I suggested), is there currently any easy way to change it? I mean either via patching the code, or changing the build flags?

@jgeboski
Copy link
Collaborator

I see, so the current behavior is that it marks messages as read when you reply to the thread?

No, it is based on focus. As soon as you focus the conversation in pidgin, it will then mark the message thread as read.

If I wanted to change that behavior (to the one I suggested), is there currently any easy way to change it? I mean either via patching the code, or changing the build flags?

Could create your own patch, but I have non handy.

@psxde
Copy link

psxde commented Oct 1, 2015

I have the same problem with purple-facebook as transport with spectrum2. It worked for months without any problem but after the last update, I receive the messages again and again on all devices. Currently the plugin is not usable anymore for this purpose. How to change it back - and - if you include any option in your plugin - how can i set them through spectrum2?

Thanks,
Patrick

@rodneyrod
Copy link

@nodevel Is it possible for your work to be adapted to desktop Telepathy clients have access to this plugin too?

@psxde
Copy link

psxde commented Oct 13, 2015

Please help: Which version I need to go back to be able to continue using purple-facebook with spectrum2?

@nodevel
Copy link
Author

nodevel commented Oct 13, 2015

@psx01de I went back to 3d30d24fdbef in my case (telepathy-haze) and it works fine.

@rodneyrod I haven't tried it, but you can look at the code (the rpm is noarch) and see for yourself:
https://openrepos.net/sites/default/files/packages/1033/haze-accounts-extensions-facebookmessenger-0.3-3.noarch.rpm

@psxde
Copy link

psxde commented Oct 13, 2015

@nodevel Thank you, it looks good!

@Thaodan
Copy link

Thaodan commented Dec 26, 2015

anyone tried to create an account with mc-tool and is able to login?

@ghost
Copy link

ghost commented Feb 22, 2016

Any chance to get this fixed? Have the same issue with spectrum2 and had to revert to 3d30d24fdbef. Maybe it is possible to customize?

@jgeboski
Copy link
Collaborator

Closed in favor of #221.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants