Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed Hebrew/Latin text is displayed in the wrong order (LTR instead of RTL) when the main language is Hebrew. #233

Closed
shlomif opened this issue Mar 30, 2016 · 11 comments
Labels

Comments

@shlomif
Copy link

shlomif commented Mar 30, 2016

Hi all - thanks for purple-facebook. I'm using it to chat with my facebook friends using pidgin-2.10.12-1.mga6 on Mageia Linux x86-64 v6. However, since I'm an Israeli and some of my friends and I communicate in mixed Hebrew/Latin text, then often when the primary language of the paragraph is Hebrew, the text gets displayed in the wrong order (left-to-right or LTR) instead of right-to-life or RTL.

Now, facebook handles it fine in its web interface and I recall it sometimes being fine in XMPP/Jabber chats.

Please look into correcting it and let me know if I can be of further assistance.

@dequis
Copy link
Owner

dequis commented Mar 30, 2016

recall it sometimes being fine in XMPP/Jabber chats.

...sometimes?

Could you try again with any other protocol to confirm?

@shlomif
Copy link
Author

shlomif commented Mar 30, 2016

@dequis: sorry for the late response. I'm trying to find someone else to talk with on some online forums. And what do you mean by 'any other protocol'? a protocol other than what exactly?

@dequis
Copy link
Owner

dequis commented Mar 30, 2016

Other than this one. XMPP is fine.

@shlomif
Copy link
Author

shlomif commented Mar 30, 2016

@dequis: Ok, thanks for the update.

@shlomif
Copy link
Author

shlomif commented Mar 30, 2016

pidgin

Hi @dequis ! It seems to be working fine in XMPP/Jabber over GMail (when both endpoints are pidgin) as this screenshot of a conversation shows. I am shlomif and the other party is borissh and as you can see the mixed Hebrew/Latin text not only is in RTL direction but also aligned to the right of the window. So it seems to be a quirk of the purple-facebook plugin.

Regards, -- @shlomif

@dequis
Copy link
Owner

dequis commented Apr 9, 2016

Can I have a screenshot of it being rendered incorrectly, when using this plugin? And copy a text version of the conversation.

This looks good to me:

@dequis
Copy link
Owner

dequis commented Apr 9, 2016

@shtrb you mentioned a similar issue with a different plugin, how does this work for you?

@shlomif
Copy link
Author

shlomif commented Apr 9, 2016

@dequis:

I've attached a screenshot of a facebook conversation:

pidgin-screenshot

As you can see - my (= Shlomi Fish's) text which starts with Hebrew is right-aligned and has an RTL direction and it says "starts with hebrew, goes to English(in English) and returns to hebrew". On the other hand, the same text as typed from my recipient is left-aligned and in an LTR paragraph direction. The key here is that the starting words should be in Hebrew so ought to be aligned and directed properly.

Update: My facebook recipient's nickname is written in English/Latin letters.

@shlomif
Copy link
Author

shlomif commented Apr 9, 2016

Just a note - my facebook recipient's name is written using Latin/English letters (completely).

@dequis
Copy link
Owner

dequis commented Apr 28, 2016

Fixed with https://bitbucket.org/pidgin/main/pull-requests/35/gtkconv-fix-alignment-of-incoming-rtl - should be included in the next pidgin release

(I forgot to close this ticket before)

@dequis
Copy link
Owner

dequis commented Jun 21, 2016

Pidgin 2.11.0 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants