After #42 still errors when no forks

[davidpfarrell]

211130-19:36:04.425 INFO: time window for stargazer/fork data: ('2020-02-18', '2021-11-28')
211130-19:36:04.425 INFO: custom time window for stargazer plot: ('2020-02-18', '2021-11-28')
Traceback (most recent call last):
  File "/analyze.py", line 1653, in <module>
    main()
  File "/analyze.py", line 134, in main
    add_fork_section(df_forks, sf_date_axis_lim, sf_starts_earlier_than_vc_data)
  File "/analyze.py", line 1244, in add_fork_section
    assert starts_earlier_than_vc_data is None
AssertionError
+ ANALYZE_ECODE=1
+ set -e
+ set +x
error: analyze.py returned with code 1 -- exit.

[jgehrcke]

Thank you! Yeah I will only release after having built automated tests : ).

[davidpfarrell]

Yeah but I need tool tips now :) It was such joy reviewing my stats yesterday :)

I've re-forked the repo and added if len() checks around add_fork_section and add_stargazers_section - This will get me through for now.

I'll keep an eye out for further commits and/or releases.

Also feel free to lemme know any time you want me to give @main a try.

I doubt all 3 of my no-fork repos will get forks between now and then - so I'll be able to help test :)

[jgehrcke]

I've done quite a bit of work in #44 to get that bug covered in automated tests. Also added a fix.

Currently, make bats-test executes three scenarios:

± make bats-test
docker run --entrypoint "/bin/bash" -v /home/jp/dev/github-repo-stats:/cwd jgehrcke/github-repo-stats-base:bfc24d971 \
	-c 'cd /cwd && bats --print-output-on-failure tests/analyze.bats'
1..3
ok 1 analyze.py: snapshots: some, vcagg: yes, stars: some, forks: none
ok 2 analyze.py: snapshots: some, vcagg: yes, stars: none, forks: some
ok 3 analyze.py: snapshots: some, vcagg: yes, stars: some, forks: some

The test cases are defined here: https://github.com/jgehrcke/github-repo-stats/blob/3aa1455e03979b96fc197e622461644a274c66dc/tests/analyze.bats

Prior to the fix, test 2 and 3 both failed with the problem you have reported here.

[davidpfarrell]

Gave the updated @main a try:

This repository has no forks yet.

👍

[jgehrcke]

Thank you for the feedback @davidpfarrell :).