allow overriding the cdc event field #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyjmoody
force-pushed
the
override-cdc-event-field
branch
from
b31b95b
to
2a24ed8
Compare
codyjmoody
force-pushed
the
override-cdc-event-field
branch
from
2a24ed8
to
051a0b0
Compare
jgilbert01
reviewed
Sep 25, 2023
| ? uow | ||
| : ({ | ||
| ...uow, | ||
| event: { |
There was a problem hiding this comment.
i would think we just need to override this field with [rule.eventField || 'event']
There was a problem hiding this comment.
in my mind the purpose of overriding the event field would be to avoid spreading the uow.event in the toEvent function like in job. I think the commit I just added has this simplification but still allows avoiding spreading uow.event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.