Skip to content

Commit

Permalink
Use truly large fictional core versions in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jglick committed Jan 26, 2024
1 parent c414546 commit f3a34b7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/src/test/java/hudson/PluginManagerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ public void noInjectionOnAvailablePluginsPage() throws Exception {
PluginManagerUtil.getCheckForUpdatesButton(p).click();
HtmlPage available = wc.goTo("pluginManager/available");
assertTrue(available.querySelector(".alert-danger")
.getTextContent().contains("This plugin is built for Jenkins 2.999"));
.getTextContent().contains("This plugin is built for Jenkins 9999999"));
wc.waitForBackgroundJavaScript(100);

HtmlAnchor anchor = available.querySelector(".jenkins-table__link");
Expand Down
2 changes: 1 addition & 1 deletion test/src/test/java/jenkins/install/InstallUtilTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public void test_typeTransitions() throws IOException, ServletException {
Assert.assertEquals(InstallState.UPGRADE, InstallUtil.getNextInstallState(InstallState.UNKNOWN));

// Fudge things yet again, changing the stored version to something very very new, faking a downgrade...
InstallUtil.saveLastExecVersion("1000.0");
InstallUtil.saveLastExecVersion("1000000.0");
Assert.assertEquals(InstallState.DOWNGRADE, InstallUtil.getNextInstallState(InstallState.UNKNOWN));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ updateCenter.post(
"previousTimestamp": "2022-05-24T12:27:03.00Z<img src=x onerror=alert(1)>",
"previousVersion": "<img src=x onerror=alert(1)>581.v0c46fa_697ffd",
"releaseTimestamp": "2022-06-29T21:02:16.00Z<img src=x onerror=alert(1)>",
"requiredCore": "2.999<img src=x onerror=alert(1)>",
"requiredCore": "9999999<img src=x onerror=alert(1)>",
"scm": "https://github.com/jenkinsci/workflow-aggregator-plugin<img src=x onerror=alert(1)>",
"sha1": "6iNlKTnXvr4W+9Svwy1+ctyqgvo=<img src=x onerror=alert(1)>",
"sha256": "P0SFgnqOBFZjxkdKORiQUbrhdlfW5YU7tOpe85bfGWE=<img src=x onerror=alert(1)>",
Expand Down

0 comments on commit f3a34b7

Please sign in to comment.