New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typo, cleaning up imports #1

Merged

jglrxavpok merged 1 commit into jglrxavpok:master from good-praxis:master

Mar 10, 2019

Contributor

good-praxis commented Mar 10, 2019

There was a typo in one of the errors ("couldn't create rener pass")
I switched to using VK_LAYER_LUNARG_standard_validation over core_validation, since this allows for more validation (standard includes core, see here), but it's an opinionated change, so just tell me if you want it changed 👍
cleaned up unnecessary imports

tested afterwards, everything still worked


          cleaning up import, switching to generic validation layer

5325e79

Owner

jglrxavpok commented Mar 10, 2019

Thank you for your contribution!
The LunarG validation is fine to me as it provides more debug information

jglrxavpok merged commit bd17f0f into jglrxavpok:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment