Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse footnote definitions with lazy continuation #127

Closed
wants to merge 1 commit into from

Conversation

notriddle
Copy link
Contributor

Fixes #126

This change brings it into alignment with GitHub, markdown-it, and hugo/goldmark.

@notriddle notriddle marked this pull request as draft November 1, 2023 05:47
@notriddle
Copy link
Contributor Author

This PR is the wrong approach. It gives "lazy paragraph continuations" that aren't supposed to work, like these two examples:

[^foo]:* bar
* baz

>* qwfp [^foo]
* arst

Continuation behavior should be the same for both, which looks like this, but the above PR doesn't do that correctly:

  • baz
  • qwfp 1
  • arst

Footnotes

    • bar

@notriddle notriddle closed this Nov 1, 2023
@jgm
Copy link
Owner

jgm commented Nov 1, 2023

Normally you shouldn't have to do anything to get lazy continuations when a blockContinue doesn't match, so I'm not sure why the original code didn't work. I'll look into it.

@notriddle notriddle deleted the notriddle/lazy-footnote branch November 1, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fuzz result] unindented lines after footnote def are silently eaten
2 participants