-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove emojis from core? #112
Comments
Another problem with emojis is that their set changes over time. So, there's (theoretical) forward compatibility hazard with To clarify, is this about removing just the emoji table (so, the user still can write |
We could go either way. I guess it would make sense to keep the emoji parsing, just remove the replacement with a unicode character. Then the filter would be quite easy and efficient; it would just have to match on the emoji elements rather than doing a pattern recognition on each str. |
Thinking about this a bit more, a case could be made for redesignating the We have extensible containers for blocks, inlines, verbatim block, verbatim inline. But we don't have an extensible leaf node -- this could be it. |
This is a good idea but please note my comment at #44 (comment) that |
https://github.com/kitsunies/emoji.lua seems to be a nice emoji library.
The tests would no longer contain resolved emojis. Either way, we could compile the support into the web playground (amalg.lua will include the module if it's installed and you ask it to). |
Let me copy my thoughts about emoji notation from #175 here. I don't think emoji notation is necessary because
|
@rhysd's excellent points boils down to: Today, |
Currently djot includes a giant table of emoji aliases so it can do substitutions for
:smile:
.While this is undoubtedly useful for some purposes, I wonder if it would be better implemented as an optional filter.
It should be relatively easy to create an emoji filter -- performance would have to be tested.
The text was updated successfully, but these errors were encountered: