max-page-size does not work properly? #343

Open
karlicoss opened this Issue Jan 26, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@karlicoss
Contributor

karlicoss commented Jan 26, 2013

Seems like max-page-size is not working properly even when set to 100K (default): if you save a page with more that 100K characters, gitit should show somewhat like "Server error: Page exceeds maximum size.", instead, it just does not apply any change to the page, and shows you the last page revision before the edit. Actually, that happens not just above 100K bytes, but this problem arises somewhere about 95K bytes — gitit just forgets the changes to the page and does not show any error.

I also tried setting max-page-size to 50K, and it works fine, if I insert less than 50K text, it saves, if I insert 60K text, it shows error. However, if I insert, for example, 100K text, it just forgets the changes.

My gitit version is 0.10.1.2, I also built 0.10.2 and reproduced the same bug. I tried to reproduce it on gitit.net, but it works as expected (unfortunately, I don't know the version of gitit installed there).

@jgm

This comment has been minimized.

Show comment Hide comment
@jgm

jgm Jan 26, 2013

Owner

A while back I fixed a bug which caused error messages not to
appear. This should be fixed in 0.10.1.2, though. What happens
when you try to save a page with an empty description? Do you
get an error message or just the page text again?

+++ Dmitry Gerasimov [Jan 26 13 01:47 ]:

Seems like max-page-size is not working properly even when set to 100K
(default): if you save a page with more that 100K characters, gitit
should show somewhat like "Server error: Page exceeds maximum size.",
instead, it just does not apply any change to the page, and shows you
the last page revision before the edit. Actually, that happens not just
above 100K bytes, but this problem arises somewhere about 95K bytes --
gitit just forgets the changes to the page and does not show any error.

I also tried setting max-page-size to 50K, and it works fine, if I
insert less than 50K text, it saves, if I insert 60K text, it shows
error. However, if I insert, for example, 100K text, it just forgets
the changes.

My gitit version is 0.10.1.2, I also built 0.10.2 and reproduced the
same bug. I tried to reproduce it on gitit.net, but it works as
expected (unfortunately, I don't know the version of gitit installed
there).

--
Reply to this email directly or [1]view it on GitHub.
[xJAuenYDiIoVt3LF3y6848DAslDCyjnQ6q-QyN4VMN_TEU5ULLK1SzGEvfugSIMi.gif]

References

  1. #343
Owner

jgm commented Jan 26, 2013

A while back I fixed a bug which caused error messages not to
appear. This should be fixed in 0.10.1.2, though. What happens
when you try to save a page with an empty description? Do you
get an error message or just the page text again?

+++ Dmitry Gerasimov [Jan 26 13 01:47 ]:

Seems like max-page-size is not working properly even when set to 100K
(default): if you save a page with more that 100K characters, gitit
should show somewhat like "Server error: Page exceeds maximum size.",
instead, it just does not apply any change to the page, and shows you
the last page revision before the edit. Actually, that happens not just
above 100K bytes, but this problem arises somewhere about 95K bytes --
gitit just forgets the changes to the page and does not show any error.

I also tried setting max-page-size to 50K, and it works fine, if I
insert less than 50K text, it saves, if I insert 60K text, it shows
error. However, if I insert, for example, 100K text, it just forgets
the changes.

My gitit version is 0.10.1.2, I also built 0.10.2 and reproduced the
same bug. I tried to reproduce it on gitit.net, but it works as
expected (unfortunately, I don't know the version of gitit installed
there).

--
Reply to this email directly or [1]view it on GitHub.
[xJAuenYDiIoVt3LF3y6848DAslDCyjnQ6q-QyN4VMN_TEU5ULLK1SzGEvfugSIMi.gif]

References

  1. #343
@karlicoss

This comment has been minimized.

Show comment Hide comment
@karlicoss

karlicoss Jan 26, 2013

Contributor

If text is rather small (90K, for example), saving it with no description results in "Description cannot be empty" message, just as expected. If it is a bit larger (99K text, for example) saving it does not result in any error message and I get the page text before the edit.

Contributor

karlicoss commented Jan 26, 2013

If text is rather small (90K, for example), saving it with no description results in "Description cannot be empty" message, just as expected. If it is a bit larger (99K text, for example) saving it does not result in any error message and I get the page text before the edit.

@karlicoss

This comment has been minimized.

Show comment Hide comment
@karlicoss

karlicoss Jan 27, 2013

Contributor

Hmm, looks like it depends not only on page size. The same, for example happens on pages with small (30 K) size, but a lot of sections/subsections. I'll try to reproduce it exactly later.

Contributor

karlicoss commented Jan 27, 2013

Hmm, looks like it depends not only on page size. The same, for example happens on pages with small (30 K) size, but a lot of sections/subsections. I'll try to reproduce it exactly later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment