Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using any reader for PageType #677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

singpolyma
Copy link
Contributor

Instead of a closed list, allow anything Pandoc understands. If there is no
markup/markupHelp file for the reader, then there will be no help, otherwise
this works as before.

Instead of special-casing +lhs this is now just a normal extension specification
understood by Pandoc. +emoji is always added as before. Reader specs are run
through toLower for compatibility with the existing system.

Closes #636
Closes #580

Instead of a closed list, allow anything Pandoc understands.  If there is no
markup/markupHelp file for the reader, then there will be no help, otherwise
this works as before.

Instead of special-casing +lhs this is now just a normal extension specification
understood by Pandoc.  +emoji is always added as before. Reader specs are run
through toLower for compatibility with the existing system.

Closes jgm#636
Closes jgm#580
@tim-janik
Copy link

Thanks for this PR, I also need to set Pandoc flags in addition to "markdown".

Locally, I've rebased the changes onto 0.15.1.0 and tried to build it.
I have Ubuntu 22.04 with pandoc 2.9.2.1 here, but still I needed to disable the condition
#if !MIN_VERSION_pandoc(2,12,0) in order for Data.Text to be qualified as T in src/Network/Gitit/Util.hs.
Also, I had to restore the data files with upper case extensions for the build to succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to pass options to pandoc? Github Flavoured Markdown
2 participants