Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect fenced code blocks in github_markdown writer? #1416

Closed
wcaleb opened this issue Jul 11, 2014 · 0 comments
Closed

Incorrect fenced code blocks in github_markdown writer? #1416

wcaleb opened this issue Jul 11, 2014 · 0 comments

Comments

@wcaleb
Copy link
Contributor

wcaleb commented Jul 11, 2014

Should the github_markdown writer be changed to bring it into closer alignment with Github Flavored Markdown documentation and the Github Pages Jekyll parsers?

Writing to github_markdown currently renders fenced code blocks with language attributes like this:

 ``` {.python}
 print 'Hello world'
 ```

Blocks like this do appear to be rendered correctly by GitHub's markdown previewer. But the spec (if it can be called such) for Github Flavored Markdown instead seems to prefer Pandoc's short form for fenced code blocks:

``` python
print 'Hello world'
```

The markdown parsers that support Github Pages (redcarpet and kramdown) also prefer the syntax without brackets. Neither of them recognizes the one that Pandoc currently outputs with github_markdown. Redcarpet (at least the one currently on Github Pages) appears to recognize the short form syntax with either tildes (as produced currently by Pandoc's markdown_phpextra writer) or back ticks.

@jgm jgm closed this as completed in 7654db9 Jul 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant